Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/4.x] d/aws_s3_object: Test key with leading ./ #35220

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[release/4.x] d/aws_s3_object: Test key with leading ./ #35220

merged 2 commits into from
Jan 10, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 10, 2024 •
edited
Loading

Description

S3 objects keys with a leading "dot slash" (./) have those characters removed by AWS SDK for Go v1.
Test this.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3ObjectDataSource_leadingDotSlash' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3ObjectDataSource_leadingDotSlash -timeout 180m
=== RUN   TestAccS3ObjectDataSource_leadingDotSlash
=== PAUSE TestAccS3ObjectDataSource_leadingDotSlash
=== CONT  TestAccS3ObjectDataSource_leadingDotSlash
--- PASS: TestAccS3ObjectDataSource_leadingDotSlash (35.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	41.579s

@ewbankkit
Add 'TestAccS3ObjectDataSource_leadingDotSlash'.
12e91ce
@ewbankkit
Acceptance test output:
504e699 
% make testacc TESTARGS='-run=TestAccS3ObjectDataSource_leadingDotSlash' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3ObjectDataSource_leadingDotSlash -timeout 180m
=== RUN   TestAccS3ObjectDataSource_leadingDotSlash
=== PAUSE TestAccS3ObjectDataSource_leadingDotSlash
=== CONT  TestAccS3ObjectDataSource_leadingDotSlash
--- PASS: TestAccS3ObjectDataSource_leadingDotSlash (35.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	41.579s
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. labels Jan 10, 2024
@ewbankkit ewbankkit changed the title [release/4.x] r/aws_s3_object: Test key with leading ./ [release/4.x] d/aws_s3_object: Test key with leading ./ Jan 10, 2024
@ewbankkit ewbankkit merged commit 7ee4abc into release/4.x Jan 10, 2024
36 of 39 checks passed
@ewbankkit ewbankkit deleted the t-release/4.x-s3-object-key-leading-dot-slash branch January 10, 2024 13:37
This was referenced Jan 10, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit